-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: Observability update #7625
Merged
romain-grecourt
merged 13 commits into
helidon-io:main
from
tomas-langer:7615-observability
Sep 22, 2023
Merged
4.x: Observability update #7625
romain-grecourt
merged 13 commits into
helidon-io:main
from
tomas-langer:7615-observability
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Sep 19, 2023
tomas-langer
added
health
4.x
Version 4.x
and removed
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
labels
Sep 19, 2023
tomas-langer
changed the title
Design proposal - observability
4.x: Design proposal - observability
Sep 19, 2023
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Sep 19, 2023
…viders in builders. This aligns the keys with builder methods, and simplifies configuration.
Add OpenApiFeature.create(Config) method
…nstants, enums before code etc.
Class model fix to correctly import arrays
tomas-langer
changed the title
4.x: Design proposal - observability
4.x: Observability update
Sep 22, 2023
romain-grecourt
approved these changes
Sep 22, 2023
barchetta
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🥇
tjquinno
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
health
metrics
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7615
Update to observability features - design proposal (health checks updated)
Usage: https://github.com/helidon-io/helidon/blob/db0245d3b99d9bc0d58d42c4fe02f6a28bb92417/webserver/tests/observe/observe/src/test/java/io/helidon/webserver/tests/observe/ObserveTest.java
Documentation